Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ember 5 #37

Merged
merged 12 commits into from
Aug 2, 2023
Merged

Upgrade ember 5 #37

merged 12 commits into from
Aug 2, 2023

Conversation

c0rydoras
Copy link
Collaborator

@c0rydoras c0rydoras commented Jul 10, 2023 •
edited
Loading

Tests will fail due to mirage not being compatible with ember-data 5 yet (miragejs/ember-cli-mirage#2444)

This PR includes

  • set async and inverse on models
  • removed usage of various deprecated methods from project-form
  • upgraded ember-{source,cli} to 4.12 (npx ember-cli-update --to 4.12)
  • changed location type to historic (auto was deprecated)
  • import and return components (power-select, power-select-multiple) instead of using ensureSafeComponent with their name
  • added useSessionSetupMethod to ember-cli-build.js
  • upgraded ember-data to 4.12 which required some extra work
  • upgraded to ember-5 by running npx ember-cli-update --to 5.0

@c0rydoras c0rydoras marked this pull request as draft July 10, 2023 15:14
@c0rydoras c0rydoras mentioned this pull request Jul 11, 2023
Closed
@c0rydoras c0rydoras marked this pull request as ready for review July 11, 2023 08:55
@c0rydoras c0rydoras requested a review from anehx July 11, 2023 08:55
anehx
anehx requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick in the eslint config, otherwise good job!

ember/.eslintrc.js Outdated Show resolved Hide resolved
@anehx
Copy link
Member

anehx commented Jul 11, 2023

LGTM, but your tests are failing.

@c0rydoras
Copy link
Collaborator Author

@anehx The tests are failing due to mirage (miragejs/ember-cli-mirage#2444)

@c0rydoras c0rydoras merged commit bcb9fcf into adfinis:main Aug 2, 2023
4 checks passed
@c0rydoras c0rydoras deleted the upgrade-ember-5 branch August 2, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anehx anehx anehx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0rydoras @anehx